Use a token name for diagnostics to generate diagnostic messages #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Sep 9, 2022
| @@ -612,8 +611,7 @@ final class DeclarationTests: XCTestCase { | |||
| diagnostics: [ | |||
| DiagnosticSpec(locationMarker: "MISSING_COLON", message: "Expected ':' in function parameter"), | |||
| DiagnosticSpec(locationMarker: "MISSING_RPAREN", message: "Expected ')' to end parameter clause"), | |||
| // FIXME: We should issues something like "Expected identifier in declaration" | |||
| DiagnosticSpec(locationMarker: "MISSING_IDENTIFIER", message: "Expected '' in struct"), | |||
| DiagnosticSpec(locationMarker: "MISSING_IDENTIFIER", message: "Expected identifier in struct"), | |||
There was a problem hiding this comment.
"in struct" sounds a little weird to me, but the change to give them names looks good to me 👍
There was a problem hiding this comment.
This will be changed to Expected name of struct in one of my future PRs. I can’t find it right now, so it looks like I haven’t put it up yet.
ahoppen
force-pushed
the
ahoppen/token-name-for-diagnostics
branch
from
4a50ae5 to
f657b60
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/token-name-for-diagnostics
branch
from
f657b60 to
fbd3d19
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/token-name-for-diagnostics
branch
from
fbd3d19 to
39e2b9a
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to generate improved error messages: