Skip to content

.swiftinterface-Related Fixes #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 8, 2022
Merged

.swiftinterface-Related Fixes #751

merged 5 commits into from
Sep 8, 2022

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Sep 8, 2022

A stack of fixes that get us parsing the declarations in swift interface files correctly.

  • Model the argument list to @_opaqueReturnTypeOf and parse it
  • Parse attributes involving both qualified names and generics
  • Rename some of the methods that got touched here to be more internally consistent.

@CodaFi CodaFi requested a review from ahoppen as a code owner September 8, 2022 21:24
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 8, 2022

@swift-ci test

@CodaFi CodaFi merged commit 1e9a9c5 into swiftlang:main Sep 8, 2022
@CodaFi CodaFi deleted the parse-for-the-course branch September 8, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CodaFi