Skip to content

Conditionalize Use of New Internal Parsing APIs #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2022
Merged

Conditionalize Use of New Internal Parsing APIs #752

merged 2 commits into from
Sep 9, 2022

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Sep 8, 2022

Provides a weak solution to #749 by assuming that the toolchain used to build SwiftSyntax is also the toolchain you're linking the internal syntax dylib out of.

@jpsim

@CodaFi
Conditionalize Use of New Internal Parsing APIs
8d51778 
Provides a weak solution to swiftlang#749 by assuming that the toolchain
used to build SwiftSyntax is also the toolchain you're linking
the internal syntax dylib out of.
@CodaFi CodaFi requested a review from ahoppen as a code owner September 8, 2022 22:23
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 8, 2022

@swift-ci test

@jpsim
Copy link
Contributor

jpsim commented Sep 8, 2022

With Xcode 14 RC 1 the UnsafeRawBufferPointer shims are also needed:

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 8, 2022

Good point. I'll just drop the gates entirely and we'll shadow these APIs for good.

@CodaFi
Drop Compiler Version Gates
0aec83a 
Xcode 14 RC1 ships with a Swift standard library that is too old to
contain these primitives despite the compiler version being new. Just
drop the gates - we can shadow these APIs in these files just fine.
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 8, 2022

@swift-ci test

@jpsim
Copy link
Contributor

jpsim commented Sep 9, 2022

This compiles with Xcode 14 RC 1 but needs to find a lib_InternalSwiftSyntaxParser.dylib for the corresponding version to parse correctly.

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 9, 2022

@swift-ci test

@CodaFi CodaFi merged commit 4a8743b into swiftlang:main Sep 9, 2022
@CodaFi CodaFi deleted the five-alarm-fire branch September 9, 2022 07:18
@ahoppen
Copy link
Member

ahoppen commented Sep 9, 2022

This compiles with Xcode 14 RC 1 but needs to find a lib_InternalSwiftSyntaxParser.dylib for the corresponding version to parse correctly.

Yes, for that you will need to use a recent swift development snapshot.

@jpsim
Copy link
Contributor

jpsim commented Sep 9, 2022

Does this need to be cherry-picked onto the release/5.7 branch? That branch also contains #453.

@jpsim
Copy link
Contributor

jpsim commented Sep 21, 2022

I believe this needs to be applied onto release/5.7 as I'm still seeing the same build errors with the 0.50700.0 release. cc @ahoppen

@jpsim jpsim mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsim jpsim jpsim approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodaFi @jpsim @ahoppen