WIP enumerate node_choices and element_choices
#765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
choices-enum
branch
from
ec76d70 to
f15005b
Compare
rintaro
commented
Sep 9, 2022
Comment on lines
8430
to
+8738
| public struct AttributeSyntax: SyntaxProtocol, SyntaxHashable { | ||
| public enum Argument: SyntaxProtocol { | ||
| case `identifier`(TokenSyntax) | ||
| case `string`(TokenSyntax) | ||
| case `integer`(TokenSyntax) |
There was a problem hiding this comment.
This is unfortunate we need to take the token kind into account.
ahoppen
reviewed
Sep 10, 2022
| } | ||
| } | ||
| init(_ data: SyntaxData) { self.init(Syntax(data))! } | ||
| public init(decl node: DeclSyntax) { self = .decl(node) } |
There was a problem hiding this comment.
I think it would also be useful to have
public init<T: DeclSyntaxProtocol>(decl node: T) so you can initialize .decl with any decl node without needing to upcast it to DeclSyntax first.
rintaro
force-pushed
the
choices-enum
branch
2 times, most recently
from
5a68117 to
7758920
Compare
rintaro
force-pushed
the
choices-enum
branch
from
7758920 to
8d88b29
Compare
|
Superseded by #1010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO NOT MERGE