Optimize SyntaxVisitor and make it a protocol
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the deferred visitation `shouldVisit` checks. They are unnecessary now. * Change `SyntaxVisitor` to a protocol. `SyntaxVisitor` was a pure abstract class, a protocol is more appropriate for it. * Minimize casts to `Syntax`/'_SyntaxBase' during visitation to improve performance * Introduce `SyntaxAnyVisitor` as separate protocol for clients that want to use a `visitAny(_:Syntax)` function. It is a separate protocol because this kind of visitation is 1.6x slower. * Move `SyntaxVerifier` to a separate source file After these changes, performance of visition has improved significantly. Depending on whether the `SyntaxVisitor` client was visiting only token nodes or all nodes, the speed-up is 5x or 6x respectively.
|
@swift-ci Please test |
harlanhaskins
approved these changes
Feb 10, 2019
|
harlanhaskins
approved these changes
Feb 10, 2019
nkcsgexi
reviewed
Feb 10, 2019
nkcsgexi
approved these changes
Feb 11, 2019
akyrtzi
added a commit
to akyrtzi/swift-stress-tester
that referenced
this pull request
Feb 11, 2019
SwiftSyntax changes are in swiftlang/swift-syntax#77
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
…-and-accessors Fix formatting for vars with default values and accessors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shouldVisitchecks. They are unnecessary now.SyntaxVisitorto a protocol.SyntaxVisitorwas a pure abstract class, a protocol is more appropriate for it.Syntax/_SyntaxBaseduring visitation to improve performanceSyntaxAnyVisitoras separate protocol for clients that want to use avisitAny(_:Syntax)function. It is a separate protocol because this kind of visitation is 1.6x slower.SyntaxVisitor.visitPre()because it doesn't seem useful, a client can put related code intovisit()instead.SyntaxVerifierto a separate source fileAfter these changes, performance of visition has improved significantly. Depending on whether the
SyntaxVisitorclient was visiting only token nodes or all nodes, the speed-up is 5x or 6x respectively.