Skip to content

Newlines Prevent Bare Slash Regex Lexing #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Sep 14, 2022

Break bare slash regex parsing at newline boundaries as well. The lexing test here was trying to pair the / operator with the comment operator several lines below, which was catching the brace in the fray.

Break bare slash regex parsing at newline boundaries as well. The
lexing test here was trying to pair the / operator with the comment
operator several lines below, which was catching the brace in the fray.
@CodaFi CodaFi requested a review from ahoppen as a code owner September 14, 2022 02:26
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 14, 2022

@swift-ci test

@CodaFi CodaFi merged commit 50729b2 into swiftlang:main Sep 14, 2022
@CodaFi CodaFi deleted the lex-luthor branch September 14, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants