A Grab Bag of Miscellaneous Parser Fixes #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
Fixup the definition of the attribute to accept a token and a set of arguments - like the rest of the DeclName-based productions. Then parse these arguments.
CodaFi
force-pushed
the
a-touch-of-gray
branch
from
3501e96 to
2f7950e
Compare
CodaFi
force-pushed
the
a-touch-of-gray
branch
from
2f7950e to
10825a7
Compare
|
@swift-ci test |
CodaFi
added a commit
to CodaFi/swift
that referenced
this pull request
Sep 15, 2022
This broke in swiftlang/swift-syntax#793 when I updated the function parameter declaration representation to include isolated and const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open(set)correctlyThis patchset gets us all the way through the compiler's validation tests (minus the two structural tests)
Swift test progress: 8264/8334 passes