Assert the Linkage of SwiftSyntax and SwiftParser #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
DougGregor
approved these changes
Sep 15, 2022
Tests/SwiftParserTest/Linkage.swift
Outdated
| try assertLinkage(of: swiftSyntaxURL) { linkages in | ||
| XCTAssertEqual(linkages, [ | ||
| .library("-lobjc"), | ||
| .library("-lswiftCompatibilityConcurrency"), |
There was a problem hiding this comment.
Should we allow-list all -lswiftCompatibility prefixes? For example, there's a -lswiftCompatibility56 that just got introduced and will kick in sometimes.
Tests/SwiftParserTest/Linkage.swift
Outdated
| try assertLinkage(of: swiftParserURL) { linkages in | ||
| XCTAssertEqual(linkages, [ | ||
| .library("-lobjc"), | ||
| .library("-lswiftCompatibilityConcurrency"), |
ahoppen
reviewed
Sep 19, 2022
CodaFi
force-pushed
the
unchained-melody
branch
2 times, most recently
from
c63375d to
5df908e
Compare
|
@swift-ci test |
CodaFi
force-pushed
the
unchained-melody
branch
from
5df908e to
33a5e76
Compare
|
@swift-ci test |
We want to keep this set as minimal as possible. To that end, provide a test on Darwin that the set of link-time dependencies remains known to us. If this set expands, this test will fail and we'll be able to investigate the dependency growth.
CodaFi
force-pushed
the
unchained-melody
branch
from
33a5e76 to
62b4086
Compare
|
@swift-ci test |
Allow for linkage conditions based on the language version and build configuration.
CodaFi
force-pushed
the
unchained-melody
branch
from
62b4086 to
217100f
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to keep this set as minimal as possible. To that end, provide a test on Darwin that the set of link-time dependencies remains known to us. If this set expands, this test will fail and we'll be able to investigate the dependency growth.