Make SyntaxKind internal
#80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SyntaxKind` was made public in order to provide a visitation check for clients. Since the visitation check has been removed there's no need for `SyntaxKind` to be public. Additional changes: * Make `SyntaxKind` have CSyntaxKind as raw type. Avoids having to convert between them. * Remove protocol `IncrementalParseLookup`. It can't be public since `SyntaxKind` is internal, and it's not much use to external clients anyway. * Rename `IncrementalEditTransition` -> `IncrementalParseTransition`.
nkcsgexi
approved these changes
Feb 11, 2019
|
@swift-ci Please test |
harlanhaskins
approved these changes
Feb 11, 2019
akyrtzi
added a commit
to akyrtzi/swift-stress-tester
that referenced
this pull request
Feb 12, 2019
… `IncrementalEditTransition` SwiftSyntax changes are in swiftlang/swift-syntax#80
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Clarify SwiftPM Products
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyntaxKindwas made public in order to provide a visitation check for clients. Since the visitation check has been removed there's no need forSyntaxKindto be public.Additional changes:
SyntaxKindhave CSyntaxKind as raw type. Avoids having to convert between them.IncrementalParseLookup. It can't be public sinceSyntaxKindis internal, and it's not much use to external clients anyway.IncrementalEditTransition->IncrementalParseTransition.