[Performance] Minimize RawTokenKindSubset.allCases usage #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
commented
Sep 16, 2022
| } | ||
|
|
||
| static var allRawTokenKinds: [RawTokenKind] { | ||
| return self.allCases.map { $0.rawTokenKind } |
There was a problem hiding this comment.
This was the main offender for the performance.
|
@swift-ci Please test |
rintaro
force-pushed
the
tokenkindsubset-noarray
branch
2 times, most recently
from
f37a23a to
e4ff692
Compare
|
@swift-ci Please test |
'allCases' is not trivial because it creates an Array. We should avoid creating temporary array if possible.
rintaro
force-pushed
the
tokenkindsubset-noarray
branch
from
e4ff692 to
4ad0a19
Compare
|
@swift-ci Please test |
CodaFi
approved these changes
Sep 16, 2022
ahoppen
reviewed
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allCasesis not trivial because it creates an Array. We should avoid creating temporary array if possible.This recovers recent performance regression (2.22s -> 1.31s)
Instead of using
allCases.map { $0.rawTokenKind }.contains(self.currentToken.tokenKind), makeRawTokenKindSubset.init(lexeme:)requirement andswitchthetokenKindin it.