Keep 'SyntaxArena's of rewritten children alive. #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
syntaxrewriter-keeparena
branch
from
e1528fd to
32bedd6
Compare
|
@swift-ci Please test |
If the rewritten node have its own arena, we can't discard the 'Syntax' without retaining the arena.
rintaro
force-pushed
the
syntaxrewriter-keeparena
branch
from
32bedd6 to
6c17323
Compare
|
@swift-ci Please test |
CodaFi
approved these changes
Sep 16, 2022
DougGregor
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.