Generalize Lexeme State into Flags #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalize the isAtStartOfLine bit into flags. In the future this will allow us to identify multiline string literals and start to diagnose erroneous tokens.
Use this to prevent the parser from having to re-infer the number of quotes it needs to eat to make progress.
|
@swift-ci test |
DougGregor
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the current "is at start of line" bit into a small flag set. On top of that, pass the lexer's "is multiline string" flag up to the parser. This mirrors the behavior of the C++ parser and makes sure we don't have to spend time re-lexing the string literal to determine this for ourselves in a completely separate component.
The important part here is that we have a space to attach a future "error" bit to the tokens, rather than yielding plain
.unknownback. This should give us the space to start issuing (what were formerly) lex-time diagnostics.