Add a public API to look up an infix operator by name. #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
DougGregor
approved these changes
Sep 17, 2022
|
I went ahead and added prefix/postfix operators and lookup functions in #819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than limit myself in with an API specifically for the precedence group, returning the full
Operatorvalue seems more flexible/future-proof.I added analogs for prefix and postfix operators, and then realized when writing tests that the
defaultOperatorsset doesn't include those yet! So I stuck with just the infix API and we can revisit prefix/postfix later—it doesn't seem right to offer those public APIs if they don't have the expected behavior when called ondefaultOperatorsyet.