Fix loop breaking condition for dictionary literal parsing. #812
Conversation
| @@ -1630,7 +1630,7 @@ extension Parser { | |||
| valueExpression: value, | |||
| trailingComma: comma, | |||
| arena: self.arena))) | |||
| if key.is(RawMissingExprSyntax.self), colon.isMissing, value.is(RawMissingExprSyntax.self) { | |||
| if key.is(RawMissingExprSyntax.self) || colon.isMissing || value.is(RawMissingExprSyntax.self) { | |||
There was a problem hiding this comment.
I am not sure if this is superior in general. IIUC if you have
[
1: "one",
2: ,
3: "three"
]we wouldn’t be stopping dictionary literal parsing at the missing value for 2 and thus not add 3: "three" to the string literal.
What do key and value contain when we synthesize the missing colon?
There was a problem hiding this comment.
Thanks for the pointer, I'll try to investigate further.
Interestingly, your example produces no diagnostics for me with the original implementation 😅
There was a problem hiding this comment.
Oh, I forgot that my example will only start producing diagnostics once #739 is merged.
|
I forgot that I already have a fix for this up as part of one of my PRs: 5731968. Because that fixes the issue, I’m closing this PR. Sorry. |
This resolves a FIXME I found in the tests - the loop break previously required the key AND colon AND value to be missing, which I don't think is even possible to satisfy.