Change endPosition to be the end of the node's length and add endPositionBeforeTrailingTrivia in its place
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ositionBeforeTrailingTrivia` in its place * It is unintuitive that `position` points at the beginning of the node and `endPosition` points at the beginning of the trailing trivia. Pointing at the end of the node is more intuitive * Now there is a symmetry for `position`/`endPosition` and `positionAfterSkippingLeadingTrivia`/`endPositionBeforeTrailingTrivia`. `position`/`endPosition` are both "cost-free" while `positionAfterSkippingLeadingTrivia`/`endPositionBeforeTrailingTrivia` requires calculating the trivia length.
|
@swift-ci Please test |
akyrtzi
added a commit
to akyrtzi/swift-stress-tester
that referenced
this pull request
Feb 13, 2019
…tionBeforeTrailingTrivia Change is from swiftlang/swift-syntax#84
nkcsgexi
approved these changes
Feb 13, 2019
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Prune some dead/unimplemented rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
positionpoints at the beginning of the node andendPositionpoints at the beginning of the trailing trivia. Pointing at the end of the node is more intuitiveposition/endPositionandpositionAfterSkippingLeadingTrivia/endPositionBeforeTrailingTrivia.position/endPositionare both "cost-free" whilepositionAfterSkippingLeadingTrivia/endPositionBeforeTrailingTriviarequires calculating the trivia length.