Skip to content

Move SwiftParser/Diagnostics to its own module #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Sep 27, 2022

Just a bit of cleanup I wanted to do to keep the modules small and focused.

The idea is that SwiftParser just creates a SwiftSyntax tree and SwiftParserDiagnositcs produces nice error messages for such a tree.

@ahoppen
Copy link
Member Author

ahoppen commented Sep 27, 2022

@swift-ci Please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this refactoring, because it keeps the parser module small and focused.

.target(
name: "SwiftOperators",
dependencies: ["SwiftSyntax", "SwiftParser", "SwiftDiagnostics"]
),
.target(
name: "SwiftCompilerSupport",
dependencies: [
"SwiftSyntax", "SwiftParser", "SwiftDiagnostics", "SwiftOperators"],
dependencies: ["SwiftSyntax", "SwiftParser", "SwiftParserDiagnostics",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need a paired PR to the Swift repository to link against SwiftParserDiagnostics.

@ahoppen ahoppen force-pushed the ahoppen/swiftparserdiagnostics-module branch from 3730f1e to a794bdb Compare October 20, 2022 07:45
@ahoppen
Copy link
Member Author

ahoppen commented Oct 20, 2022

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/swiftparserdiagnostics-module branch from a794bdb to e5dff6b Compare October 21, 2022 09:18
@ahoppen
Copy link
Member Author

ahoppen commented Oct 21, 2022

@swift-ci Please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like this idea.

@ahoppen ahoppen force-pushed the ahoppen/swiftparserdiagnostics-module branch 2 times, most recently from 5ef0f3c to b40b000 Compare October 22, 2022 14:28
@ahoppen
Copy link
Member Author

ahoppen commented Oct 22, 2022

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/swiftparserdiagnostics-module branch from b40b000 to 402ab05 Compare October 22, 2022 14:49
@ahoppen
Copy link
Member Author

ahoppen commented Oct 22, 2022

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/swiftparserdiagnostics-module branch from 402ab05 to 16a7268 Compare October 22, 2022 16:38
@ahoppen
Copy link
Member Author

ahoppen commented Oct 22, 2022

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 22, 2022

swiftlang/swift-stress-tester#205

@swift-ci Please test

Just a bit of cleanup I wanted to do to keep the modules small and focused.

The idea is that SwiftParser just creates a SwiftSyntax tree and SwiftParserDiagnositcs produces nice error messages for such a tree.
@ahoppen ahoppen force-pushed the ahoppen/swiftparserdiagnostics-module branch from a5f1eb0 to 3f7fb2e Compare October 23, 2022 06:55
@ahoppen
Copy link
Member Author

ahoppen commented Oct 23, 2022

swiftlang/swift-stress-tester#205

@swift-ci Please test

@ahoppen ahoppen merged commit 1bde900 into swiftlang:main Oct 23, 2022
@ahoppen ahoppen deleted the ahoppen/swiftparserdiagnostics-module branch October 23, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants