-
Notifications
You must be signed in to change notification settings - Fork 441
Move SwiftParser/Diagnostics to its own module #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SwiftParser/Diagnostics to its own module #849
Conversation
@swift-ci Please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this refactoring, because it keeps the parser module small and focused.
.target( | ||
name: "SwiftOperators", | ||
dependencies: ["SwiftSyntax", "SwiftParser", "SwiftDiagnostics"] | ||
), | ||
.target( | ||
name: "SwiftCompilerSupport", | ||
dependencies: [ | ||
"SwiftSyntax", "SwiftParser", "SwiftDiagnostics", "SwiftOperators"], | ||
dependencies: ["SwiftSyntax", "SwiftParser", "SwiftParserDiagnostics", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need a paired PR to the Swift repository to link against SwiftParserDiagnostics
.
3730f1e
to
a794bdb
Compare
@swift-ci Please test |
a794bdb
to
e5dff6b
Compare
@swift-ci Please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I like this idea.
5ef0f3c
to
b40b000
Compare
@swift-ci Please test |
b40b000
to
402ab05
Compare
@swift-ci Please test |
402ab05
to
16a7268
Compare
@swift-ci Please test |
16a7268
to
a5f1eb0
Compare
swiftlang/swift-stress-tester#205 @swift-ci Please test |
Just a bit of cleanup I wanted to do to keep the modules small and focused. The idea is that SwiftParser just creates a SwiftSyntax tree and SwiftParserDiagnositcs produces nice error messages for such a tree.
a5f1eb0
to
3f7fb2e
Compare
swiftlang/swift-stress-tester#205 @swift-ci Please test |
Just a bit of cleanup I wanted to do to keep the modules small and focused.
The idea is that
SwiftParser
just creates a SwiftSyntax tree andSwiftParserDiagnositcs
produces nice error messages for such a tree.