Model parameter modifiers as a ModifierList
#861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/text-choices-for-isolated
branch
from
3397fe4 to
ccc9623
Compare
|
@swift-ci Please test |
ahoppen
changed the title
isolated and _const token in FunctionParameterModifierList
ahoppen
force-pushed
the
ahoppen/text-choices-for-isolated
branch
from
ccc9623 to
d06bb9c
Compare
rintaro
approved these changes
Sep 30, 2022
1 similar comment
This allows more flexibility in the future if more parameters get added in the future and if those might be ordered arbitrarily. It also makes fixing a parsing issue in the C++ parser easier.
ahoppen
force-pushed
the
ahoppen/text-choices-for-isolated
branch
from
d06bb9c to
e54f1d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more flexibility in the future if more parameters get added in the future and if those might be ordered arbitrarily. It also makes fixing a parsing issue in the C++ parser easier.