Rewrite Format to recursively format an entire SwiftSyntax tree #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/rewrite-format
branch
2 times, most recently
from
59f177d to
c19de99
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/rewrite-format
branch
from
c19de99 to
7dec961
Compare
Previously, `Format` required very delicate interaction with SwiftSyntaxBuilder because it did not format a syntax tree recursively. This tight coupling was difficult to understand and even harder to describe. With the new split, `SwiftBasicFormat` can also be used outside of SwiftSyntaxBuilder.
ahoppen
force-pushed
the
ahoppen/rewrite-format
branch
from
7dec961 to
f7c30f1
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Formatrequired very delicate interaction with SwiftSyntaxBuilder because it did not format a syntax tree recursively. This tight coupling was difficult to understand and even harder to describe. With the new split,SwiftBasicFormatcan also be used outside of SwiftSyntaxBuilder.