Make Trivia and TriviaPiece Equatable #89
Merged
+74
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartbit
force-pushed
the
trivia-equatable-hashable
branch
from
5cc8bc5 to
339b018
Compare
nkcsgexi
requested changes
Feb 18, 2019
|
I can downgrade it to Equatable, but why do you want custom == checks instead of relying on the compiler synthesized one? |
|
You’re right. Thinking more about this, the synthesized conformance should work just fine here. |
hartbit
force-pushed
the
trivia-equatable-hashable
branch
from
339b018 to
c3ba26c
Compare
|
@nkcsgexi done! |
hartbit
changed the title
nkcsgexi
approved these changes
Feb 18, 2019
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Use a closure instead of a keypath in a call to `map`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing a
SyntaxRewriter, I need to check that some trivia was 'correct' or not before attempting to fix it, and was surprised that I couldn't compare Trivia easily. I've now addedHashableconformance to bothTriviaandTriviaPiece.