Remove print-init subcommand from swift-parser-cli
#908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/no-dependency-cli-xctest
branch
from
ea895b8 to
c755fcb
Compare
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
`debugInitCall`, which is the backbone of `swift-parser-cli` is defined in `_SwiftSyntaxTestSupport`, which links against XCTest. If `swift-parser-cli` links against `_SwiftSyntaxTestSupport`, it also links against `XCTest`, causing its execution to fail with a dyld error outside of Xcode. The solution would be to move `debugInitCall` into a new module that `swift-parser-cli` can link against but IMHO the `print-init` subcommand doesn’t provide sufficent value for that since you most likely want to use it in test cases where you can use a debugger command to get the `debugInitCall` result: `e print(tree.debugInitCall)`.
ahoppen
force-pushed
the
ahoppen/no-dependency-cli-xctest
branch
from
c755fcb to
f33b3fc
Compare
|
@swift-ci Please test |
|
Unfortunate. I'd still be fine with it being a part of |
|
It can’t be part of SwiftSyntax because it uses SwiftSyntaxBuilder. We could add it to the SwiftSyntaxBuilder module but that also really doesn’t seem like the right place to put it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debugInitCall, which is the backbone ofswift-parser-cliis defined in_SwiftSyntaxTestSupport, which links against XCTest. Ifswift-parser-clilinks against_SwiftSyntaxTestSupport, it also links againstXCTest, causing its execution to fail with a dyld error outside of Xcode.The solution would be to move
debugInitCallinto a new module thatswift-parser-clican link against but IMHO theprint-initsubcommand doesn’t provide sufficent value for that since you most likely want to use it in test cases where you can use a debugger command to get thedebugInitCallresult:e print(tree.debugInitCall).