Diagnose ';' statements #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add diagnostics for code block items that only contain a semicolon.
|
@swift-ci Please test |
bnbarham
reviewed
Oct 10, 2022
| @@ -72,6 +72,7 @@ public enum StaticParserError: String, DiagnosticMessage { | |||
| case editorPlaceholderInSourceFile = "editor placeholder in source file" | |||
| case missingColonInTernaryExprDiagnostic = "expected ':' after '? ...' in ternary expression" | |||
| case missingFunctionParameterClause = "expected argument list in function declaration" | |||
| case stanaloneSemicolonStatement = "';' statements are not allowed" | |||
There was a problem hiding this comment.
Suggested change
| case stanaloneSemicolonStatement = "';' statements are not allowed" | |
| case standaloneSemicolonStatement = "';' statements are not allowed" |
Also I know this is what the old diagnostic was, but could we add standalone to the start? We could also make some better suggestions depending on the context, ie. in a switch suggest break. Possibly fallthrough as well, though that's semantically different.
There was a problem hiding this comment.
Thanks for the typo, also adding “standalone” to the error message makes sense to me. The Fix-It to replace it with break doesn’t really seem worth it. I don’t think there are very many C developers switching to Swift anymore that are expecting ';' statements to work around the requirement that switch cases must have an executable statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add diagnostics for code block items that only contain a semicolon.