[Parse] Avoid 'inout' operator passing in Character.Info testing #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing `var` value with `&` operator triggers TSAN "modifying access" detection even though it doesn't actually mutates the value. That results "access race" sanitizer error in multi-thread environments. Instead of using a tuple table, use 'switch' to test the character info. Also, eliminate unused character info value, and introduce 'IDENT_CONT'
|
@swift-ci Please test |
CodaFi
approved these changes
Oct 12, 2022
| return self.testRawInfoTable { entry in | ||
| !entry.intersection([ .UPPER, .LOWER, .UNDER, ]).isEmpty | ||
| } | ||
| self.testCharacterInfo(.IDENT_CONT) && !self.isDigit && self != "$" |
There was a problem hiding this comment.
Maybe we should burn a bit for identifier starts too.
|
@swift-ci Please test |
jpsim
added a commit
to realm/SwiftLint
that referenced
this pull request
Oct 13, 2022
jpsim
added a commit
to realm/SwiftLint
that referenced
this pull request
Oct 13, 2022
jpsim
added a commit
to realm/SwiftLint
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
varvalue with&operator triggers TSAN "modifying access" detection even though it doesn't actually mutates the value. That results "access race" sanitizer error in multi-thread environments.Instead of using a tuple table, use 'switch' to test the character info. Also, eliminate unused character info value, and introduce 'IDENT_CONT'
#893
rdar://100906576