Skip to content

If a missing token has a child name, use that instead of the generic token kind #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

If a missing token has a child name, use that instead of the generic token kind #935

merged 1 commit into from
Oct 12, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 12, 2022

No description provided.

@ahoppen ahoppen requested a review from bnbarham October 12, 2022 07:33
@ahoppen ahoppen force-pushed the ahoppen/token-child-name branch from 972a26e to 7cec10f Compare October 12, 2022 09:42
@ahoppen
Copy link
Member Author

ahoppen commented Oct 12, 2022

@swift-ci Please test

@ahoppen ahoppen merged commit f9b715a into swiftlang:main Oct 12, 2022
@ahoppen ahoppen deleted the ahoppen/token-child-name branch October 12, 2022 17:14
@bnbarham
Copy link
Contributor

I prefer identifier personally. Did this change any others? Can't see any except identifier -> name, but I could just be missing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham