Skip to content

Improve recovery in precedence groups #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 13, 2022

No description provided.

@ahoppen ahoppen requested a review from bnbarham October 13, 2022 17:15
@ahoppen
Copy link
Member Author

ahoppen commented Oct 13, 2022

@swift-ci Please test

@ahoppen ahoppen merged commit 4738296 into swiftlang:main Oct 13, 2022
@ahoppen ahoppen deleted the ahoppen/recovery-in-precedencegroup branch October 13, 2022 19:51
precedencegroup D {
assignment: 4️⃣no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth having a fix-it here to cover common cases? no/NO/FALSE/0/etc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don’t think so. If you are declaring precedence groups but haven’t understood how Swift specifies booleans, I don’t care about you, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants