Skip to content

Improve recovery of unknown pound literals #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 13, 2022

No description provided.

@ahoppen ahoppen requested a review from bnbarham October 13, 2022 20:01
@ahoppen
Copy link
Member Author

ahoppen commented Oct 13, 2022

@swift-ci Please test

let _ = [1️⃣#Color(colorLiteralRed: red, green: green, blue: blue, alpha: alpha)#]
let _ = [2️⃣#Image(imageLiteral: localResourceNameAsString)#]
let _ = [3️⃣#FileReference(fileReferenceLiteral: localResourceNameAsString)#]
let _ = [1️⃣#Color(colorLiteralRed: red, green: green, blue: blue, alpha: alpha)2️⃣#]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we need to have parser support for these ancient object literals.

@ahoppen ahoppen merged commit a09903d into swiftlang:main Oct 14, 2022
@ahoppen ahoppen deleted the ahoppen/pound-literal-recovery branch October 14, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant