Parse an ellipsis T... for type parameter packs
#948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a generic parameter list, parse an ellipsis to produce a type parameter pack. This replaces the previous `@_typeSequence` attribute.
This is no longer needed now that we have the ellipsis spelling.
|
@swift-ci please test |
CodaFi
approved these changes
Oct 15, 2022
ahoppen
reviewed
Oct 17, 2022
Comment on lines
+1123
to
+1129
| // Detect an attempt to use a type parameter pack. | ||
| var unexpectedAfterName: RawUnexpectedNodesSyntax? | ||
| if let ellipsis = tryConsumeEllipsisPrefix() { | ||
| unexpectedAfterName = RawUnexpectedNodesSyntax( | ||
| elements: [RawSyntax(ellipsis)], arena: self.arena) | ||
| } | ||
|
|
There was a problem hiding this comment.
There is a convenience initializer on RawUnexpectedNodesSyntax that fails if it is passed only nil elements, so this can be simplified to
let ellipsis = tryConsumeEllipsisPrefix()and then below where you are currently passing unexpectedAfterName to the RawAssociatedtypeDeclSyntax initializer:
RawUnexpectedNodesSyntax(ellipsis, arena: self.arena)| @@ -145,6 +145,29 @@ public class ParseDiagnosticsGenerator: SyntaxAnyVisitor { | |||
| addDiagnostic(incorrectContainer, message(misplacedTokens), fixIts: fixIts, handledNodes: [incorrectContainer.id] + correctAndMissingTokens.map(\.id)) | |||
| } | |||
|
|
|||
| /// Utility function to remove a misplaced token with a custom error message. | |||
There was a problem hiding this comment.
If you agree, I think the following comment is a little more descriptive.
/// If `unexpected` only contains a single token that satisfies `predicate` emit a diagnostic with `message` that removes this token.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a generic parameter list, parse an ellipsis to produce a type parameter pack. This replaces the previous
@_typeSequenceattribute.