Add diagnostic if deinits have names and parameters #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/deinits-with-name
branch
from
1b57308 to
820768b
Compare
|
@swift-ci Please test |
bnbarham
reviewed
Oct 18, 2022
| DiagnosticSpec(message: "deinitializers cannot have parameters", fixIts: ["remove function signature"]), | ||
| ], fixedSource: """ | ||
| class FooClassDeinitializerA { | ||
| deinit{} |
There was a problem hiding this comment.
Unfortunate that we remove the trailing trivia here. But adding it in would make the deinit x(a: Int) { case look silly instead 🤷.
| @@ -403,4 +393,14 @@ final class InitDeinitTests: XCTestCase { | |||
| ) | |||
| } | |||
|
|
|||
| func testDeinitInSwiftinterfaceIsFollowedByFinalFunc() { | |||
| AssertParse( | |||
There was a problem hiding this comment.
Could you check the structure here? This could also be parsed as
deinit final
func foo()
depending on recovery. Do we already have:
class Foo {
func foo() final
func bar()
}
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.