Introduce a SyntaxRawRewriter that is more performant than SyntaxRewriter #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iter `SyntaxRawRewriter` is pretty much equivalent to `SyntaxRewriter` but the `visit` methods return raw syntax nodes, which makes `SyntaxRawRewriter` more performant than `SyntaxRewriter`. The motivation for this is that `BasicFormat` needs to be written in terms of `SyntaxRawRewriter` to get it to an acceptable performance level.
|
@swift-ci Please test |
rintaro
reviewed
Oct 18, 2022
|
|
||
| // Rewritten children just to keep their 'SyntaxArena' alive until they are | ||
| // wrapped with 'Syntax' | ||
| var rewrittens: ContiguousArray<RawSyntax> = [] |
There was a problem hiding this comment.
This doesn't do the job because RawSyntax doesn't retain the arena.
| let absoluteRaw = AbsoluteRawSyntax(raw: child, info: info) | ||
| let data = SyntaxData(absoluteRaw, parent: syntaxNode) | ||
|
|
||
| let rewritten = visit(data) |
There was a problem hiding this comment.
Even at this point, we can't know the arena of rewritten is alive or not.
So it must be the rewriter (sub classes)'s responsibly to keep the arenas alive until the rewriting completes.
|
Thinking about this again, I realized that this performance optimization isn’t actually necessary, #977 is sufficient to get acceptable performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyntaxRawRewriteris pretty much equivalent toSyntaxRewriterbut thevisitmethods return raw syntax nodes, which makesSyntaxRawRewritermore performant thanSyntaxRewriter.The motivation for this is that
BasicFormatneeds to be written in terms ofSyntaxRawRewriterto get it to an acceptable performance level.