Skip to content

Bridge Parser Diagnostics into the C++ Diagnostic Engine #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

Bridge Parser Diagnostics into the C++ Diagnostic Engine #976

merged 1 commit into from
Oct 20, 2022

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Oct 19, 2022

No description provided.

@CodaFi CodaFi requested a review from ahoppen as a code owner October 19, 2022 04:40
@CodaFi CodaFi mentioned this pull request Oct 19, 2022
Merged
@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 19, 2022

swiftlang/swift#61631

@swift-ci test

ahoppen
ahoppen reviewed Oct 19, 2022
View reviewed changes
@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 19, 2022

swiftlang/swift#61631

@swift-ci test

DougGregor
DougGregor approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should the round-trip failures go through this new diagnostic hook, too?

@CodaFi CodaFi merged commit c09d8a1 into swiftlang:main Oct 20, 2022
@CodaFi CodaFi deleted the locavore branch October 20, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodaFi @DougGregor @ahoppen