[classifier] Provide a more efficient classification mechanism #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide 'classifications' as a sequence of (kind, range) values. This allows using the same type to classify source ranges across tokens and trivia pieces and makes the classification mechanism much more efficient since we avoid providing syntax nodes and the resulting casts to `_SyntaxBase` for establishing the parent hierarchy. The new classification mechanism is 10.2x faster than the previous mechanism, and 2.7x faster than using the SyntaxVisitor.
|
@swift-ci Please test |
harlanhaskins
approved these changes
Mar 4, 2019
nkcsgexi
reviewed
Mar 5, 2019
| /// - Parameters: | ||
| /// - in: The relative byte range to pull `SyntaxClassifiedRange`s from. | ||
| /// - Returns: Sequence of `SyntaxClassifiedRange`s. | ||
| public func classifications(in range: ByteSourceRange) -> SyntaxClassifications { |
There was a problem hiding this comment.
Could we migrate the location structures here to SourceRange?
There was a problem hiding this comment.
It's easy to get a ByteSourceRange from SourceRange, the other way is not so convenient.
I would prefer not to require a SourceRange in this API but just add a var byteRange: ByteSourceRange property to SourceRange. If you have a SourceRange just pass its byteRange property to this API.
nkcsgexi
approved these changes
Mar 5, 2019
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Don't remove spaces around a range operator followed by a prefix dot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide 'classifications' as a sequence of (kind, range) values.
This allows using the same type to classify source ranges across tokens and trivia pieces and makes the classification mechanism much more efficient since we avoid providing syntax nodes and the resulting casts to
_SyntaxBasefor establishing the parent hierarchy.The new classification mechanism is 10.2x faster than the previous mechanism, and 2.7x faster than using the SyntaxVisitor.