Remove name_for_diagnostics='name' #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
bnbarham
reviewed
Oct 19, 2022
| @@ -5,7 +5,7 @@ | |||
| # labeled-stmt -> label ':' stmt | |||
| Node('LabeledStmt', name_for_diagnostics='labeled statement', kind='Stmt', | |||
| children=[ | |||
| Child('LabelName', kind='IdentifierToken', name_for_diagnostics='name'), | |||
| Child('LabelName', kind='IdentifierToken', name_for_diagnostics='label name'), | |||
There was a problem hiding this comment.
Doesn't seem to be a test for this case?
There was a problem hiding this comment.
I don’t actually think we ever hit this right now because we only parse a labeled statement if there is a label. But I think it doesn’t hurt either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bnbarham We chatted about this before. Do you think the new error messages are better? I don’t really have strong opinions.