Fix link to Swift Forums #1001
Merged
Fix link to Swift Forums #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZevEisenberg
requested review from
stmontgomery,
grynspan,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
added
bug
grynspan
approved these changes
Mar 7, 2025
|
@shahmishal Is there any way to get redirects working in the forums? |
|
Docs change only, can skip CI. |
stmontgomery
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Thank you! You are correct: we should include the trailing 103 digits in the URL, that is what allows Discourse forum URLs to properly redirect if a category is moved, and the problem is we didn't include those digits originally or the link wouldn't have broken. Lesson learned!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken link to Swift forums.
Motivation:
The old link was a 404.
Old link: https://forums.swift.org/c/related-projects/swift-testing
New link: https://forums.swift.org/c/development/swift-testing/103
Modifications:
I looked on the forum and tried to find the most canonical version of the link. When I remove the
/103, it still loads with a 301 Moved Permanently. I'm not sure whether including the/103in the URL or not is more future-proof, but at least this way we prevent a redirect.Result:
The link works again.
Checklist: