Skip to content

Add a reserved argument to the test content record accessor signature. #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

Add a reserved argument to the test content record accessor signature. #1017

merged 2 commits into from
Mar 12, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Mar 12, 2025 •
edited
Loading

This PR adds a reserved argument to __TestContentRecordAccessor for our future use.

Resolves rdar://146818672.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added enhancement New feature or request tools integration 🛠️ Integration of swift-testing into tools/IDEs labels Mar 12, 2025
@grynspan grynspan added this to the Swift 6.2 milestone Mar 12, 2025
@grynspan grynspan self-assigned this Mar 12, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

1 similar comment
@grynspan
Copy link
Contributor Author

@swift-ci test

grynspan added 2 commits March 12, 2025 13:10
@grynspan
Add a reserved argument to the test content record accessor signature.
bc15cd8 
This PR adds a `reserved` argument to `__TestContentRecordAccessor` for our
future use.
@grynspan
Use UInt instead of a pointer for consistency
7b7d7f9
@grynspan grynspan force-pushed the jgrynspan/add-reserved-accessor-arg branch from 6152f73 to 7b7d7f9 Compare March 12, 2025 17:10
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit 4399cba into main Mar 12, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/add-reserved-accessor-arg branch March 12, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom briancroom approved these changes

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
enhancement New feature or request tools integration 🛠️ Integration of swift-testing into tools/IDEs
Projects
None yet
Milestone
Swift 6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @briancroom