Skip to content

Mark XCTestScaffold to-be-deprecated. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Dec 12, 2023

Currently, the documentation for XCTestScaffold has a "warning" callout to indicate that it is a temporary interface. This PR replaces the callout with a formal deprecation attribute so that the type and its members show as deprecated in our documentation. They are marked as deprecated in Swift 100000.0, which is a "magic" version number used in Apple's SDK to indicate "to-be-deprecated" status.

This change does not cause new diagnostics to be emitted at compile-time; it affects documentation only.

Before

Screenshot 2023-12-12 at 6 47 40 PM

After

Screenshot 2023-12-12 at 6 51 36 PM

And, when referenced from another article:

Screenshot 2023-12-12 at 6 46 11 PM

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

Currently, the documentation for `XCTestScaffold` has a "warning" callout to indicate that it is a temporary interface. This PR replaces the callout with a formal deprecation attribute so that the type and its members show as deprecated in our documentation. They are marked as deprecated in Swift 100000.0, which is a "magic" version number used in Apple's SDK to indicate "to-be-deprecated" status.
@grynspan grynspan force-pushed the jgrynspan/to-be-deprecated-xctestscaffold branch from cecae56 to a1e889c Compare December 12, 2023 23:51
@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan grynspan merged commit 593327a into main Dec 13, 2023
@grynspan grynspan deleted the jgrynspan/to-be-deprecated-xctestscaffold branch December 13, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants