Expand property accesses in #expect() and #require().
#161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, swift-testing is able to expand member function accesses like `foo.bar()` into `foo` and `bar()` so that it can provide the values of both subexpressions on expectation failure. This PR enables the same sort of functionality for property accesses (`foo.isBar`). This PR also ensures that optional chaining in either member function calls or property accesses is observed so that an expression like `foo?.bar()` will not fail to compile.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, swift-testing is able to expand member function accesses like
foo.bar()intofooandbar()so that it can provide the values of both subexpressions on expectation failure. This PR enables the same sort of functionality for property accesses (foo.isBar).This PR also ensures that optional chaining in either member function calls or property accesses is observed so that an expression like
foo?.bar()will not fail to compile.Checklist: