Report an error when attempting to use --filter or --skip in unsupported environments #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the SwiftPM entry point argument parsing logic to ensure that if a user passes the
--filter
or--skip
flags on an OS version which does not support those features, an error is reported.Motivation:
Currently, we silently ignore these flags on unsupported OS versions but that can cause problems if the user was only expecting certain tests to run, so this ensures that we either honor the user's request or report a meaningful failure message.
Modifications:
else
branch ofif #available(...)
conditions which guard the implementations of these CLI flags.Checklist:
Resolves rdar://119837856