Skip to content

Fix syntax of #expect(throws:) example in documentation #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2024
Merged

Fix syntax of #expect(throws:) example in documentation #172

merged 2 commits into from
Jan 4, 2024

Conversation

stmontgomery
Copy link
Contributor

Fix syntax of #expect(throws:) example in documentation

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added the documentation 📚 Improvements or additions to documentation label Jan 4, 2024
@stmontgomery stmontgomery self-assigned this Jan 4, 2024
SeanROlszewski
SeanROlszewski approved these changes Jan 4, 2024
View reviewed changes
Copy link

@SeanROlszewski SeanROlszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@stmontgomery
Copy link
Contributor Author

@swift-ci please test

grynspan
grynspan requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@grynspan grynspan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix Expectation+Macro.swift on lines 79 and 156.

@stmontgomery stmontgomery requested a review from grynspan January 4, 2024 20:20
@grynspan
Copy link
Contributor

grynspan commented Jan 4, 2024

@swift-ci please test

@grynspan grynspan merged commit c8c1110 into main Jan 4, 2024
@grynspan grynspan deleted the fix-expect-throws-syntax branch January 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanROlszewski SeanROlszewski SeanROlszewski approved these changes

@grynspan grynspan grynspan approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@stmontgomery stmontgomery

Labels
documentation 📚 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stmontgomery @grynspan @SeanROlszewski