Parallelize tests by default. #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables parallelization by default when using `swift test` and enables support for the `--no-parallel` flag in `swift test` added in swiftlang/swift-package-manager#7231. The default value of `Configuration.isParallelizationEnabled` remains `false`. Other adopters are free to enable or disable parallelization by default. `XCTestScaffold` is not affected. It is a shim used with XCTest in Swift 5.10 only and expects serial execution of tests.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
added
enhancement
|
@swift-ci please test |
|
@swift-ci test |
|
@swift-ci please test |
stmontgomery
approved these changes
Jan 5, 2024
|
@swift-ci please test |
|
Remaining failure is a SwiftPM regression tracked as rdar://120560817. All tests are passing in CI and it would be green except for a false |
grynspan
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jan 8, 2024
This PR makes the `--parallel` flag on the swift-test subtool invertible
with a "no" prefix.
We want swift-testing to default to enabling parallelization, but we
don't want to break XCTest (which for historical reasons strongly
prefers serial testing.) Deprecating `--parallel` and replacing it with
`--{enable,disable}-parallelism` or similar seems a bit heavy-handed.
Swift Argument Parser gives us the option to use a "no" prefix instead
which means that the existing `--parallel` option will continue to work
as intended.
Support for `--no-parallel` in swift-testing is here:
swiftlang/swift-testing#174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables parallelization by default when using
swift testand enables support for the--no-parallelflag inswift testadded in swiftlang/swift-package-manager#7231.The default value of
Configuration.isParallelizationEnabledremainsfalse. Other adopters are free to enable or disable parallelization by default.XCTestScaffoldis not affected. It is a shim used with XCTest in Swift 5.10 only and expects serial execution of tests.Checklist: