Console output should prefix messages with "Suite" instead of "Test" for suites #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for suites Resolves rdar://120962053
stmontgomery
requested review from
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
grynspan
reviewed
Jan 16, 2024
| @@ -142,6 +142,14 @@ extension Event.HumanReadableOutputRecorder { | |||
| } | |||
| } | |||
|
|
|||
| extension Test { | |||
There was a problem hiding this comment.
I'd prefer to make this just a function local to the file rather than extension because the extension implies something a bit stronger than just "this is the string this recorder uses" to me.
There was a problem hiding this comment.
Also "title" seems like the wrong noun, but that's probably a bit too nitpicky.
There was a problem hiding this comment.
Open to suggestions but this is just private to the file so I'm not too concerned by the word "title"
grynspan
requested changes
Jan 16, 2024
|
@swift-ci please test |
grynspan
approved these changes
Jan 16, 2024
|
There are known issues impacting CI currently so merging based on local testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the console output to prefix messages with the word "Suite" instead of "Test" for events representing suites.
Motivation:
It's helpful to users to distinguish between test functions (aka "tests") and suite types (aka "suites") in the human-readable console output shown while running tests, to clarify the role each item plays.
Modifications:
Event.HumanReadableOutputRecorderto check for suites and use the appropriate word.Result:
Console output now shows "Suite" for suites.
Checklist:
Resolves rdar://120962053