Locked shouldn't be a property wrapper.
#185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Property wrappers, when used as static properties, are inherently concurrency-unsafe (because they must be `var`, not `let`.) Discussed with the core Swift folks; this PR removes property wrapper "conformance" from `Locked`, adds `RawRepresentable` to replace it, and modifies call sites as appropriate. Resolves rdar://121054518.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please clean test |
grynspan
added
concurrency
Sources/Testing/Support/Locked.swift
Outdated
| @@ -25,7 +25,6 @@ private import TestingInternals | |||
| /// - Bug: The state protected by this type should instead be protected using | |||
| /// actor isolation, but actor-isolated functions cannot be called from | |||
| /// synchronous functions. ([83888717](rdar://83888717)) | |||
| @propertyWrapper | |||
| struct Locked<T>: @unchecked Sendable where T: Sendable { | |||
There was a problem hiding this comment.
Do we still think the single word "Locked" is a good name for this type, given that it's no longer a property wrapper?
There was a problem hiding this comment.
I think it's fine, because you'd pronounce it Locked<Int> or similar. I'm open to alternatives (LockedValue<Int> sounds silly to me though.)
|
@swift-ci please test |
stmontgomery
approved these changes
Jan 16, 2024
|
CI failures are unrelated to this PR and are being tracked elsewhere; changes have been verified at desk on Linux and macOS. |
grynspan
added a commit
that referenced
this pull request
Jan 17, 2024
Follow-up to #185. I missed a use of `wrappedValue` and because our CI is broken, I didn't notice the failure.
2 tasks
grynspan
added a commit
that referenced
this pull request
Jan 17, 2024
Follow-up to #185. I missed a use of `wrappedValue` and because our CI is broken, I didn't notice the failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property wrappers, when used as static properties, are inherently concurrency-unsafe (because they must be
var, notlet.) Discussed with the core Swift folks; this PR removes property wrapper "conformance" fromLocked, addsRawRepresentableto replace it, and modifies call sites as appropriate.Resolves rdar://121054518.
Checklist: