Skip to content

Change Graph's 'mapValues' APIs to pass key path in addition to value to transform closure #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2024
Merged

Change Graph's 'mapValues' APIs to pass key path in addition to value to transform closure #372

merged 2 commits into from
Apr 24, 2024

Conversation

stmontgomery
Copy link
Contributor

This is a small change which begins passing key path in addition to value to Graph's mapValue and compactMapValue APIs.

Motivation:

This was extracted out from work in #366, and is initially intended for use in that PR but is a generally-useful enhancement.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added the enhancement New feature or request label Apr 23, 2024
@stmontgomery stmontgomery self-assigned this Apr 23, 2024
@stmontgomery stmontgomery mentioned this pull request Apr 23, 2024
Merged
2 tasks
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

grynspan
grynspan reviewed Apr 23, 2024
View reviewed changes
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery
Copy link
Contributor Author

macOS and Linux CI are failing due to a SwiftPM issue, but I have successfully built and tested this on macOS locally.

@grynspan
Copy link
Contributor

Tested on Ubuntu at desk. All tests pass.

@stmontgomery stmontgomery merged commit 6676949 into main Apr 24, 2024
@stmontgomery stmontgomery deleted the mapValues branch April 24, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grynspan grynspan grynspan approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@stmontgomery stmontgomery

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stmontgomery @grynspan