Ensure tests representing containing types of suites are synthesized if necessary #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
force-pushed
the
synthesize-parent-suites
branch
from
904876a to
295d2ff
Compare
stmontgomery
force-pushed
the
synthesize-parent-suites
branch
4 times, most recently
from
fd29a86 to
569a036
Compare
|
@swift-ci please test Linux |
stmontgomery
requested review from
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
briancroom
reviewed
Nov 6, 2024
briancroom
reviewed
Nov 6, 2024
briancroom
reviewed
Nov 6, 2024
briancroom
approved these changes
Nov 6, 2024
stmontgomery
added
enhancement
|
@swift-ci please test |
grynspan
reviewed
Nov 8, 2024
grynspan
reviewed
Nov 8, 2024
grynspan
reviewed
Nov 8, 2024
grynspan
reviewed
Nov 8, 2024
grynspan
reviewed
Nov 11, 2024
grynspan
reviewed
Nov 13, 2024
grynspan
reviewed
Nov 13, 2024
…ized if necessary Resolves rdar://127770218
stmontgomery
force-pushed
the
synthesize-parent-suites
branch
from
6db41b3 to
f53ddaf
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that when a suite is nested in one or more containing suite types, and those outer suites do not have an explicit
@Suiteattribute, we synthesizeTestinstances representing all containing suites.Checklist:
Resolves rdar://127770218