Skip to content

Explicitly add visionOS availability to tests that check availability (Take 2) #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

briancroom
Copy link
Contributor

Re-attempt the change from #424 now that we require a Swift 6 toolchain to building the package.

@briancroom
Copy link
Contributor Author

@swift-ci please test

@stmontgomery
Copy link
Contributor

Package.swift defines an API availability macro _distantFuture, should we add a fake visionOS 99.0 to that list?

@stmontgomery stmontgomery added the bug 🪲 Something isn't working label Jun 13, 2024
Copy link
Contributor

@stmontgomery stmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion about the package manifest but LGTM otherwise

@briancroom
Copy link
Contributor Author

@swift-ci please test

@briancroom briancroom merged commit 21b13a0 into main Jun 13, 2024
3 checks passed
@briancroom briancroom deleted the bcroom/visionOS-availability branch June 13, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants