Ensure that a CustomExecutionTrait's teardown logic occurs _after_ nested tests run.
#526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nested tests run. This PR reorders operations in `Runner` such that a test with a custom execution trait will execute operations in this order: 1. Custom execution trait "before" logic; 1. Test logic; 1. Child test logic; and finally 1. Custom execution trait "after" logic. There is currently a bug here where child test logic runs _after_ the custom execution trait runs its "after" logic, which is not intentional. Resolves rdar://125115497.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
changed the title
CustomExecutionTrait's teardown logic occurs _after_ …CustomExecutionTrait's teardown logic occurs _after_ nested tests run.
|
@swift-ci please test |
dennisweissmann
approved these changes
Jul 8, 2024
|
@swift-ci please test |
stmontgomery
reviewed
Jul 8, 2024
stmontgomery
reviewed
Jul 8, 2024
stmontgomery
approved these changes
Jul 8, 2024
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/125115497-fix-order-of-custom-execution-trait-operations
branch
from
30613ff to
4fa783e
Compare
|
@swift-ci please test |
grynspan
deleted the
jgrynspan/125115497-fix-order-of-custom-execution-trait-operations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorders operations in
Runnersuch that a test with a custom execution trait will execute operations in this order:There is currently a bug here where child test logic runs after the custom execution trait runs its "after" logic, which is not intentional.
Resolves rdar://125115497.
Checklist: