Avoid fork-bombing ourselves when hosted by swift-test.
#528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR amends exit tests' child process spawning logic to ensure that they don't trigger a fork bomb or fail outright when the test process is hosted by Swift Package Manager (as in [this branch](https://github.com/swiftlang/swift-package-manager/tree/jgrynspan/one-test-product-two-libraries)). Exit tests are an experimental feature, but one that we use internally in our own test suite, so we need to make sure our tests continue to function if/when that SwiftPM branch is merged.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
stmontgomery
approved these changes
Jul 10, 2024
|
See also: swiftlang/swift-package-manager#7766 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR amends exit tests' child process spawning logic to ensure that they don't trigger a fork bomb or fail outright when the test process is hosted by Swift Package Manager (as in this branch).
Exit tests are an experimental feature, but one that we use internally in our own test suite, so we need to make sure our tests continue to function if/when that SwiftPM branch is merged.
Checklist: