Work around a bug in the older Swift compiler used to build swift-syntax in the toolchain, which affected certain result builder APIs #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tax in the toolchain, which affected certain result builder APIs
stmontgomery
added
workaround
stmontgomery
requested review from
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
|
Booooourns |
grynspan
approved these changes
Jul 16, 2024
2 tasks
grynspan
reviewed
Jul 16, 2024
| } | ||
| } | ||
| // | ||
| // Intentionally avoid using the result builder variant of these APIs due to |
There was a problem hiding this comment.
Is there a swift-syntax or swift PR/issue you can point to here? For future reference.
There was a problem hiding this comment.
Nobody involved in the investigation was sure what exactly the problem was, but in any event, the bug itself has long been fixed. We believe it was fixed in Swift 5.10. The problem is Swift's CI, in this case at least, is building some early dependencies using Swift 5.9 or earlier (intentionally), and that compiler had the bug.
There was a problem hiding this comment.
Alrighty. And the bug only affected this use of a result builder? How strange!
briancroom
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a bug which was identified while working towards adding swift-testing to Swift toolchains. See the code comment for a more detailed explanation.
Modifications:
Use a different variant of this swift-syntax API in our macro plugin to avoid the bug.
Result:
Building in the toolchain avoids the failure this was causing.
Checklist: