Allow non-final classes to act as suites.
#550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we require Swift 6, we can see the names of classes during `@Test` macro expansion. This was the primary blocker preventing us from allowing non-`final` classes, because we had to substitute `Self` for the class name and this was invalid if the suite type could be covariant. We can drop the constraint now.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
|
Nice, thank you! |
briancroom
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we require Swift 6, we can see the names of classes during
@Testmacro expansion. This was the primary blocker preventing us from allowing non-finalclasses, because we had to substituteSelffor the class name and this was invalid if the suite type could be covariant. We can drop the constraint now.Note that test functions are not heritable.
Checklist: