Skip to content

Explicitly import Foundation in IssueTests.swift. #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Jul 23, 2024

If XCTest is unavailable, IssueTests.swift fails to compile due to a Foundation dependency (that was transitively satisfied by importing XCTest which reexports Foundation). Add an explicit import of Foundation in this file to resolve the issue.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

If XCTest is unavailable, IssueTests.swift fails to compile due to a Foundation
dependency (that was transitively satisfied by importing XCTest which reexports
Foundation). Add an explicit import of Foundation in this file to resolve the
issue.
@grynspan grynspan added bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support labels Jul 23, 2024
@grynspan grynspan self-assigned this Jul 23, 2024
@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan
Copy link
Contributor Author

Caught while testing swiftlang/swift-package-manager#7805.

@grynspan
Copy link
Contributor Author

Self-reviewing.

@grynspan grynspan merged commit 2802522 into main Jul 23, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/import-foundation-in-issuetests branch July 23, 2024 16:16
@grynspan grynspan added the self-reviewed PR was self-reviewed by a code owner label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support self-reviewed PR was self-reviewed by a code owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant