Skip to content

build: tweak for portability with exceptions #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Sources/_TestingInternals/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,14 @@ add_library(_TestingInternals STATIC
WillThrow.cpp)
target_include_directories(_TestingInternals PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}/include)
target_compile_options(_TestingInternals PRIVATE
-fno-exceptions)
if("${CMAKE_CXX_COMPILER_FRONTEND_VARIANT}" STREQUAL "MSVC" OR
"${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
target_compile_options(_TestingInternals PRIVATE
/EHa-c)
else()
target_compile_options(_TestingInternals PRIVATE
-fno-exceptions)
endif()

if(NOT BUILD_SHARED_LIBS)
# When building a static library, install the internal library archive
Expand Down