Use os_unfair_lock on Darwin when available.
#942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the `Locked` type to be generic over the type of lock it uses, allowing us to adopt `os_unfair_lock` in most places, but also allowing us to use other lock types as needed (i.e. `pthread_mutex_t` in WaitFor.swift if libdispatch is unavailable.) Under `-O`, locking and unlocking is fully inlined, while initialization (which is relatively rare) is partially, but not completely, inlined.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
stmontgomery
reviewed
Feb 5, 2025
stmontgomery
reviewed
Feb 5, 2025
Co-authored-by: Stuart Montgomery <[email protected]>
|
@swift-ci test |
stmontgomery
approved these changes
Feb 5, 2025
|
@swift-ci test |
stmontgomery
reviewed
Feb 6, 2025
stmontgomery
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Lockedtype to be generic over the type of lock it uses, allowing us to adoptos_unfair_lockin most places, but also allowing us to use other lock types as needed (i.e.pthread_mutex_tin WaitFor.swift if libdispatch is unavailable.)Under
-O, locking and unlocking is fully inlined, while initialization (which is relatively rare) is partially, but not completely, inlined.Checklist: